I would like to report two issues that I have encountered while using MarketKing in a WordPress + WooCommerce environment. These issues appear to be directly related to the plugin’s code and its compatibility with PHP 8.2.
1) Deprecated Warning – Function Parameter Order
Error message:
Deprecated: Optional parameter $order declared before required parameter $currency is implicitly treated as a required parameter in /home/USERNAME/public_html/wp-content/plugins/marketking-pro/includes/stripe/class-marketking-stripe-helper.php on line 42
File & line:
/marketking-pro/includes/stripe/class-marketking-stripe-helper.php → line 42
Analysis:
The function defines an optional parameter ($order) before a required parameter ($currency).
Since PHP 8.0, this parameter declaration order raises a deprecation notice. This may lead to compatibility issues in future PHP versions if not adjusted.
2) Undefined Variable $stores_slug
Error message:
Warning: Undefined variable $stores_slug in /home/USERNAME/public_html/wp-content/plugins/marketking-multivendor-marketplace-for-woocommerce/includes/class-marketking-core.php on line [exact line may vary, but warning is triggered during execution]
Analysis:
The variable $stores_slug is being used without being initialized beforehand. This results in a PHP warning and may affect URL generation or slug handling for vendor stores. Proper initialization or a conditional check for this variable would prevent the warning.
Summary
Both of these issues reduce stability and forward compatibility of the plugin under PHP 8.2. I kindly request that these be addressed in the next MarketKing release to ensure smooth operation in modern hosting environments.
Please confirm whether these bugs are scheduled for fixing in the upcoming update.
Hi,
I would like to report two issues that I have encountered while using MarketKing in a WordPress + WooCommerce environment. These issues appear to be directly related to the plugin’s code and its compatibility with PHP 8.2.
1) Deprecated Warning – Function Parameter OrderError message:
File & line: /marketking-pro/includes/stripe/class-marketking-stripe-helper.php → line 42
Analysis: The function defines an optional parameter ($order) before a required parameter ($currency). Since PHP 8.0, this parameter declaration order raises a deprecation notice. This may lead to compatibility issues in future PHP versions if not adjusted.
2) Undefined Variable $stores_slugError message:
File & location: /marketking-multivendor-marketplace-for-woocommerce/includes/class-marketking-core.php
→ line 452 and 458
Analysis: The variable $stores_slug is being used without being initialized beforehand. This results in a PHP warning and may affect URL generation or slug handling for vendor stores. Proper initialization or a conditional check for this variable would prevent the warning.
SummaryBoth of these issues reduce stability and forward compatibility of the plugin under PHP 8.2. I kindly request that these be addressed in the next MarketKing release to ensure smooth operation in modern hosting environments.
Please confirm whether these bugs are scheduled for fixing in the upcoming update.
Best regards,
Fabrice NTANKOUO
Hi Fabrice,
Thank you for the detailed bug report and for taking the time to share this.
I can confirm both issues you've identified are now resolved in our internal versions and will be fixed as well in the next updates.
If you prefer it, I can also share them here so you can update manually on your site. Alternatively, you can wait until the next official update.
Kind regards,
Stefan